pull down to refresh

|

<jnewbery> This change is in the handling of the INV/GETDATA/TX message exchange, and is an attempt to fix a bug introduced in #14897 where our node could potentially stop asking peers to send us new transactions.

123 sats \ 7 replies \ @optimism 3h

where is this from? Because the comment change can hardly be what jnewbery describes.

reply
reply
87 sats \ 2 replies \ @optimism 2h

That's from 2018?

reply
82 sats \ 0 replies \ @Scroogey 2h

Supposedly the bug was introduced then, I haven't yet found the context where it is discussed now.

reply

2019

reply
reply

Ah. I think that that in turn was replaced by txrequestmanager and then enhanced with txdownloadman on top.

reply

It’s from an old PR review I am trying to get a better understanding of the bitcoin codebase.

reply