pull down to refresh

34 sats \ 13 replies \ @sox 13 Feb \ parent \ on: Stacker Saloon

Got it! On it.

write
preview
1 sat \ 12 replies \ @0xbitcoiner 13 Feb

I think you just gotta subtract the bar’s height from the auto-scroll.

reply
33 sats \ 0 replies \ @sox 13 Feb
reply
69 sats \ 10 replies \ @sox 13 Feb

Autoscroll on text boxes is a browser native feature, as such we’re not controlling any of it.

This does not happen on the browsers I’m using (Safari, Brave), at least to the extent of my testing capabilities (lol). Anyhow this might happen, we’ll want to make sure the editor never gets shadowed by the sticky bar so let’s see if your suggestion can be applied ^^

What is your browser?

reply
101 sats \ 9 replies \ @0xbitcoiner 13 Feb

brave! ahahah (not trolling)

reply
122 sats \ 4 replies \ @optimism 14 Feb

I don't have it on Brave (osx) either!

But I do have it on Vanadium (graphene)

reply
101 sats \ 3 replies \ @sox 14 Feb

yesterday I finally succeeded in reproducing it on Brave (osx)

  1. go here
  2. focus the first editor
  3. scroll down
  4. write something
  5. editor is shadowed by the topbar.

the fix is all about telling the browser that we need from 60px (topbar + padding) to 90px (topbar + padding + editor toolbar) of space at the top when scrolling.

reply
101 sats \ 2 replies \ @optimism 14 Feb

OK

It behaves differently on mobile for me. just look at the cap:

reply
101 sats \ 1 reply \ @sox 14 Feb

I think it makes sense for the editor to be cut at the bottom, but not at the top lol.

The problem was that some browsers scroll to the caret not the element. I address this in this PR

reply
101 sats \ 0 replies \ @optimism 14 Feb

I have a theory in my head of how to build a regression test framework for something like this. If/when I get to lift this out of the idea phase into a practical solution, I can probably make time to build it for you.

reply on another page
70 sats \ 0 replies \ @snail 13 Feb

Can confirm I am experiencing the exact same issue. Brave browser.

__@_'-'

reply
1 sat \ 2 replies \ @sox 13 Feb

😭

reply
1 sat \ 1 reply \ @0xbitcoiner 13 Feb

I’ll see if I can turn that off in Brave, or maybe it’s better not to?

edit: Looks like that option doesn’t exist in Brave!

reply
22 sats \ 0 replies \ @sox 13 Feb

Hey if autoscroll is working for everything but not for our editor, then the problem is our editor, not the autoscroll!

Will get back to you once I got a fix ^^

reply